-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to go 1.18 #2745
update to go 1.18 #2745
Conversation
needs https://github.com/golangci/golangci-lint/releases/tag/v1.45.0 |
|
|
For the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples that use go need to be updated as well
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
util/resolver/retryhandler/retry.go
Outdated
@@ -70,3 +70,16 @@ func retryError(err error) bool { | |||
|
|||
return false | |||
} | |||
|
|||
// isTemporaryNetworkError returns false unless the error implements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this. We already have a typed struct and that has Temporary()
method. There is no need to pass it as an interface and then detect the method again. This looks like a very complicated(and not type-safe) way to trick the analysis in the linter.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com